Eliminate pre-built assets during source-build #22072
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This work eliminates using pre-built NuGet packages during source-build. * Ensure Microsoft.CodeAnalysis participates in dependency flow * Remove unnecessary reference to Microsoft.Win32.Registry, this library is referenced automatically in net6.0 and net472 * Remove hard-coded Roslyn versions in ApiCompatibility and use the Roslyn version used in the SDK * Clean up the Razor source generator dependency and comment
eerhardt
requested review from
MichaelSimons,
captainsafia,
dseefeld,
dsplaisted,
safern and
sfoslund
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
safern
approved these changes
Oct 15, 2021
src/Compatibility/Microsoft.DotNet.ApiCompatibility/Microsoft.DotNet.ApiCompatibility.csproj
Show resolved
Hide resolved
dseefeld
approved these changes
Oct 15, 2021
MichaelSimons
approved these changes
Oct 15, 2021
Member
Author
|
FYI @dsplaisted @captainsafia @sfoslund - I plan on merging this change today to unblock source-build pre-built work. If you could take a look that would be great. |
sfoslund
approved these changes
Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work eliminates using pre-built NuGet packages during source-build.
Contributes to dotnet/source-build#2422